-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Singlezone commercial hydronic adrenalin #703
Open
EttoreZ
wants to merge
9
commits into
ibpsa:issue702_single_zone_commercial_adrenalin_update
Choose a base branch
from
HWalnum:singlezone_commercial_hydronic_Adrenalin
base: issue702_single_zone_commercial_adrenalin_update
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Singlezone commercial hydronic adrenalin #703
EttoreZ
wants to merge
9
commits into
ibpsa:issue702_single_zone_commercial_adrenalin_update
from
HWalnum:singlezone_commercial_hydronic_Adrenalin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tef:HWalnum/project1-boptest into singlezone_commercial_hydronic_Adrenalin
@HWalnum correct me if I am wrong, the documentation still needs to be updated and then it is ready review, right? |
@EttoreZ. Yes, that is correct. I will try to have a look at it this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address #702 to merge Adrenalin changes to
single_zone_commercial_hydronic
model. Furthermore, these updates should help address #635 and #432