deps: update to http-parser 2.3.2

Fixes http-parser regression with IS_HEADER_CHAR check Add test case for obstext characters (> 0x80) in header PR-URL: nodejs/node#5241 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
ibmruntimes · Nov 4, 2016 · 4ed472e · 4ed472e
1 parent 6564979
commit 4ed472e
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/deps/http_parser/Makefile b/deps/http_parser/Makefile
@@ -19,7 +19,7 @@
 # IN THE SOFTWARE.
 
 PLATFORM ?= $(shell sh -c 'uname -s | tr "[A-Z]" "[a-z]"')
-SONAME ?= libhttp_parser.so.2.3.1
+SONAME ?= libhttp_parser.so.2.3.2
 
 CC?=gcc
 AR?=ar

diff --git a/deps/http_parser/http_parser.c b/deps/http_parser/http_parser.c
@@ -388,7 +388,7 @@ enum http_host_state
  * character or %x80-FF
  **/
 #define IS_HEADER_CHAR(ch)                                                     \
-  (ch == CR || ch == LF || ch == 9 || (ch > 31 && ch != 127))
+  (ch == CR || ch == LF || ch == 9 || ((unsigned char)ch > 31 && ch != 127))
 
 #define start_state (parser->type == HTTP_REQUEST ? s_start_req : s_start_res)
 

diff --git a/deps/http_parser/http_parser.h b/deps/http_parser/http_parser.h
@@ -27,7 +27,7 @@ extern "C" {
 /* Also update SONAME in the Makefile whenever you change these. */
 #define HTTP_PARSER_VERSION_MAJOR 2
 #define HTTP_PARSER_VERSION_MINOR 3
-#define HTTP_PARSER_VERSION_PATCH 1
+#define HTTP_PARSER_VERSION_PATCH 2
 
 #include <sys/types.h>
 #if defined(_WIN32) && !defined(__MINGW32__) && (!defined(_MSC_VER) || _MSC_VER<1600)

diff --git a/test/simple/test-http-header-obstext.js b/test/simple/test-http-header-obstext.js
@@ -0,0 +1,18 @@
+'use strict';
+
+var common = require('../common');
+var http = require('http');
+var assert = require('assert');
+
+var server = http.createServer(common.mustCall(function(req, res) {
+  res.end('ok');
+}));
+server.listen(common.PORT, function() {
+  http.get({
+    port: common.PORT,
+    headers: {'Test': 'Düsseldorf'}
+  }, common.mustCall(function(res) {
+    assert.equal(res.statusCode, 200);
+    server.close();
+  }));
+});