build,win: fix node.exe resource version

When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but passes it correctly to cl.exe. Hence, this workaround was made to apply only to the resource file. Fixes: nodejs/node#2963 PR-URL: nodejs/node#3053 Reviewed-By: Alexis Campailla <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
ibmruntimes · Nov 4, 2016 · 15c4ac2 · 15c4ac2
1 parent ebb9f10
commit 15c4ac2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/res/node.rc b/src/res/node.rc
@@ -53,8 +53,8 @@ BEGIN
             VALUE "CompanyName", "Joyent, Inc"
             VALUE "ProductName", "Node.js"
             VALUE "FileDescription", "Evented I/O for V8 JavaScript"
-            VALUE "FileVersion", NODE_VERSION_STRING
-            VALUE "ProductVersion", NODE_VERSION_STRING
+            VALUE "FileVersion", NODE_EXE_VERSION
+            VALUE "ProductVersion", NODE_EXE_VERSION
             VALUE "OriginalFilename", "node.exe"
             VALUE "InternalName", "node"
             VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license."