Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test cases for datatypes #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

priyankaku
Copy link

Contributes to: event-integration/eventstreams-planning#12893
Signed-off-by: Priyanka.K.U [email protected]

@Joel-hanson
Copy link
Contributor

@priyankaku I have updated your branch against main, but I don't have access to you repo to push those changes. could you please provide the access to push the changes.

Contributes to: event-integration/eventstreams-planning#12893
Signed-off-by: Priyanka.K.U <[email protected]>
@Joel-hanson Joel-hanson force-pushed the test-data-types-12893 branch 5 times, most recently from c00cb98 to 0756fc5 Compare September 4, 2024 08:48
@Joel-hanson
Copy link
Contributor

Joel-hanson commented Sep 4, 2024

The latest changes in the github action is to configure the timezone to suite the tests timezone.

Currently the tests check for datatype:

  • Date
  • Time
  • Timestamp

@Joel-hanson
Copy link
Contributor

Initial testing identified that the Converter doesn't support logical types (Decimal, Timestamp, Time, Date) - only the primitive/base types.

We've started investigating what would be involved to add support for logical types.

Here is an example of what would be needed to add support for Decimal - the other logical types will be similar.

Remember: Converters can be used in two directions:

SOURCE (Map/Struct/etc. -> XML string)
schemas.enable = true

input: Struct, that includes a Connect schema
output: XML, and an XSD schema

schemas.enable = false

input: Struct, that includes a Connect schema
output: XML

input: Map (with no schema information)
output: XML

SINK (XML string -> Map/Struct)
schemas.enable = true

input: XML, with XSD xs:decimal with no further restrictions
output: Connect Struct, and a Connect Schema - mapping the xs:decimal to a double

input: XML, with XSD xs:decimal with fractionDigit restrictions on precision
output: Connect Struct, and a Connect Schema - mapping the xs:decimal to a Decimal logical type

schemas.enable = false

input: XML
output: Map

So there are six scenarios that need to be addressed before we can claim the Converter supports the Decimal logical type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants