Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox: checkmark in wrong position on iOS and Firefox #601

Closed
wkeese opened this issue Mar 7, 2016 · 0 comments
Closed

Checkbox: checkmark in wrong position on iOS and Firefox #601

wkeese opened this issue Mar 7, 2016 · 0 comments
Assignees
@wkeese
Labels
bug
Milestone
0.8.2

Comments

@wkeese
Copy link
Member

wkeese commented Mar 7, 2016

Perhaps the same as #408, but I noticed this on iOS in samples/Buttons.html:

screen shot 2016-03-07 at 11 03 23 pm
@wkeese wkeese changed the title Checkbox looks wrong on IOS Checkbox: checkmark in wrong position on iOS and Firefox Mar 9, 2016
@wkeese wkeese added the bug label Mar 9, 2016
@wkeese wkeese self-assigned this Mar 9, 2016
@wkeese wkeese added this to the 0.8.2 milestone Mar 9, 2016
@wkeese wkeese closed this as completed in 72810d2 Mar 9, 2016
wkeese added a commit that referenced this issue Mar 18, 2016
@wkeese
Specify font-family: Times for Checkbox and RadioButton font icons.
7eedb7f 
Avoids alignment issues if the page is using a custom font.

It would be better though if deliteful had its own checkmark and circle
font icons, because that would get a uniform look across browsers.

Refs #408, #601.
wkeese added a commit that referenced this issue Apr 14, 2016
@wkeese
Put icon inside aria-hidden="true" <span> so that JAWS doesn't announ…
c6b4ccb 
…ce it.

Refs #408, #601.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkeese wkeese

Labels
bug
Projects
None yet
Milestone
0.8.2
Development

No branches or pull requests
1 participant
@wkeese