Skip to content

Commit

Permalink
refactor: drop support for Ibis 3.x
Browse files Browse the repository at this point in the history
BREAKING CHANGE: The minimum supported version of Ibis is 4.0.
Deprecated methods `sort_by` and `groupby` have been removed in Ibis
6.x, so it is not possible to support 3.x through 6.x.
  • Loading branch information
gforsyth committed Aug 2, 2023
1 parent 401bb60 commit 9ffaf99
Show file tree
Hide file tree
Showing 7 changed files with 92 additions and 165 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,6 @@ jobs:
- os: windows-latest
python-version: "3.11"
ibis-version: "5.1"
- os: ubuntu-latest
python-version: "3.10"
ibis-version: "3.2"


steps:
Expand Down Expand Up @@ -136,10 +133,6 @@ jobs:
ibis-version:
- "4.1"
- "5.1"
include:
- os: ubuntu-latest
python-version: "3.10"
ibis-version: "3.2"

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions ibis_substrait/compiler/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ def extension_lookup(
if function_extension is None:
sigkey = tuple(
[
IBIS_SUBSTRAIT_TYPE_MAPPING[arg.op().output_dtype.name] # type: ignore
IBIS_SUBSTRAIT_TYPE_MAPPING[arg.output_dtype.name] # type: ignore
for arg in op.args
if arg is not None and isinstance(arg, (ir.Expr, ops.Node))
if arg is not None and isinstance(arg, ops.Node)
]
)
function_extension = _extension_mapping[op_name].get(sigkey)
Expand Down
Loading

0 comments on commit 9ffaf99

Please sign in to comment.