No deviation if near bus stop #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br648
approved these changes
Feb 11, 2025
| @@ -126,6 +128,13 @@ private static TrackingResponse doUpdateTracking( | |||
| create || rerouted | |||
| ); | |||
|
|
|||
| if (isDeviatedWithOnTrackInstruction(tripStatus, instruction)) { | |||
| // Deem traveler on track (not deviated) if they are in the 'upcoming' range of a bus stop | |||
| // or the departure loaction. | |||
| if (isDeviatedWithOnTrackInstruction(tripStatus, instruction)) { | ||
| // Deem traveler on track (not deviated) if they are in the 'upcoming' range of a bus stop | ||
| // or the departure loaction. | ||
| // (If near a bus stop, applicable bus notifications would have already been triggered. |
There was a problem hiding this comment.
Typo: Missing closing bracket.
| * Returns the closest transit leg in 'upcoming' radius eligible for a "Wait for transit" instruction. | ||
| */ | ||
| public Leg getTransitLegWithClosestUpcomingOrigin() { | ||
| double distance1 = distanceToTransitLegOrigin(currentPosition, expectedLeg); |
There was a problem hiding this comment.
Nit. Perhaps name these distanceToExpectedLeg and distanceToNextLeg ?
| @@ -667,6 +703,11 @@ public TraceData(Coordinates position, String expectedInstruction, String messag | |||
| this(position, expectedInstruction, false, message); | |||
| } | |||
|
|
|||
| public TraceData(Coordinates position, String expectedInstruction, Instant instant, String message) { | |||
There was a problem hiding this comment.
The TraceData class could now benefit from being refactored to use the builder pattern and being moved into it's own class. Perhaps out of scope, will let you decide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR addresses instances when a traveler in the 'upcoming' range of a bus stop (or the departure point of an itinerary) would see a "Wait for bus" (or "upcoming" instruction) instruction and still be deemed deviated.