Shared Stops Validator SS_01: only consider stops from feed being checked #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br648
reviewed
Feb 1, 2024
| Stop syntheticStop = new Stop(); | ||
| syntheticStop.stop_id = stopId; | ||
| if (feedId.equals(sharedStopFeedId)) { | ||
| if (seenStopIds.contains(stopId)) { | ||
| registerError(stops |
There was a problem hiding this comment.
I'm pretty sure this can be simplified to the following because syntheticStop equals stopId:
registerError(syntheticStop, NewGTFSErrorType.MULTIPLE_SHARED_STOPS_GROUPS);
There was a problem hiding this comment.
We prefer not using synthetic stop if possible, since synthetic stop can't link to the editor
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
br648
approved these changes
Feb 2, 2024
daniel-heppner-ibigroup
approved these changes
Feb 12, 2024
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
The shared stop validator was checking every stop from every feed. This sometimes created insane errors. This PR resolves this issue by adjusting some conditions so that only sensible stops are shown.