chore: cleanup deprecated things #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanen
commented
Jan 18, 2025
| @@ -1074,7 +1074,7 @@ M.convert_reload_actions = function(reload_cmd, opts) | |||
| end | |||
| end | |||
| end | |||
| if has_reload and reload_cmd and type(reload_cmd) ~= "string" then | |||
| if opts.silent ~= true and has_reload and reload_cmd and type(reload_cmd) ~= "string" then | |||
| utils.warn( | |||
| "actions with `reload` are only supported with string commands, using resume fallback") | |||
There was a problem hiding this comment.
This warn me every time when I use lsp picker seems due to I set a global actions.files with reload actions.
phanen
commented
Jan 18, 2025
| @@ -509,7 +509,8 @@ local function gen_lsp_contents(opts) | |||
| if utils.tbl_isempty(results) then | |||
| if not opts.fn_reload and not opts.silent then | |||
| utils.info(string.format("No %s found", string.lower(lsp_handler.label))) | |||
| else | |||
| end | |||
| if opts.fn_reload then | |||
There was a problem hiding this comment.
Seems a bug introduced from (a81d18e): FzfLua lsp_xxx silent=true will always launch fzf even when no results.
ibhagwan
force-pushed
the
chore-cleanup
branch
from
bb5df80 to
90b3d05
Compare
* legacy `opts.preview_window` -> `fzf_opts.--preview_window`
* `vim.fn.termopen` -> `vim.fn.jobstart` + `{ term = true }`
* `vim.loop` -> `vim.uv`
* `vim.lsp.diagnostics.get_line_diagnostics` -> `vim.lsp.diagnostic.get`
* remove term workaround 9a755f2 (fixed now)
* `opts.silent` when `reload` fallback to `resume`
ibhagwan
force-pushed
the
chore-cleanup
branch
from
90b3d05 to
9567e05
Compare
|
Tysm @phanen, this is very helpful. Did tiny 2 modifications:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opts.preview_window->fzf_opts.--preview_windowvim.fn.termopen->vim.fn.jobstart+{ term = true }vim.loop->vim.uvvim.lsp.diagnostics.get_line_diagnostics->vim.lsp.diagnostic.getopts.silentwhenreloadfallback toresume