Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp_definitions with jump_to_single_result doesn't work #980

Closed
kapral18 opened this issue Jan 2, 2024 · 8 comments
Closed

lsp_definitions with jump_to_single_result doesn't work #980

kapral18 opened this issue Jan 2, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@kapral18
Copy link

kapral18 commented Jan 2, 2024

Info

  • Operating System: MacOS Sonoma 14.2.1
  • Shell: fish
  • Terminal: iterm2
  • nvim --version: v0.10.0-dev-2016+g5dc0bdfe9
  • fzf --version: 0.45.0

Description

For example if I try to jump to definiton of running_procs_by_buf from this line https://github.com/mfussenegger/nvim-lint/blob/4dbc7ec60b33b656f7c54bb945671a55b18699f2/lua/lint.lua#L198C5-L198C5

Without jump_to_single_result it properly jumps to the definition after selecting the item in picker, but with jump_to_single_result it just stays in place

my config: https://github.com/kapral18/config.nvim/blob/dee5f388194a315bfbf7d8587b7d3ce8de9dbe60/lua/plugins/fzf.lua

@ibhagwan ibhagwan added the bug Something isn't working label Jan 2, 2024
@ibhagwan
Copy link
Owner

ibhagwan commented Jan 2, 2024

@kapral18, 949f3ca - should work as expected now.

@kapral18
Copy link
Author

kapral18 commented Jan 2, 2024

@ibhagwan you are the best, thank you!

@ibhagwan
Copy link
Owner

ibhagwan commented Jan 2, 2024

@ibhagwan you are the best, thank you!

Ty for pointing out the exact location where this happens @kapral18, saved me some time figuring out what happened there :)

@kapral18
Copy link
Author

kapral18 commented Jan 2, 2024

@ibhagwan of course my pleasure

but unfortunatley I have another one connected to this now I keep getting this notification that no definitions were found

CleanShot 2024-01-02 at 23 23 14

@ibhagwan
Copy link
Owner

ibhagwan commented Jan 2, 2024

I keep getting this notification that no definitions were found

I just tried at the exact same code location your cursor is placed in the screenshot, can you let me know better how to reproduce this? Does this happen all the time or after a while? At what exact location?

@ibhagwan
Copy link
Owner

ibhagwan commented Jan 2, 2024

Also can you try running :FzfLua lsp_definitions cwd_only=false and lmk if that works?

@ibhagwan
Copy link
Owner

ibhagwan commented Jan 2, 2024

@kapral18, try f4f3671 - should work this time around, the message was errornous, it was still performing the jump.

@kapral18
Copy link
Author

kapral18 commented Jan 2, 2024

@ibhagwan yes that's the fix. Thank you again!

Repository owner deleted a comment from kapral18 Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants