Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: make get_last_query work correctly in hide profile #1731

Closed
1 task done
phanen opened this issue Jan 19, 2025 · 0 comments · Fixed by #1733
Closed
1 task done

Feature: make get_last_query work correctly in hide profile #1731

phanen opened this issue Jan 19, 2025 · 0 comments · Fixed by #1733
Labels
feature request New feature

Comments

@phanen
Copy link
Contributor

phanen commented Jan 19, 2025

Have you RTFM'd?

  • I have done proper research

Feature Request

Problem

Continue of #1686 (comment)

Solution
@phanen phanen added the feature request New feature label Jan 19, 2025
@phanen phanen mentioned this issue Jan 19, 2025
Closed
1 task
ibhagwan added a commit that referenced this issue Jan 19, 2025
@ibhagwan
fix(hide): better solution for storing last query on esc
b35c495 
This commit partially reverts 85fa30e.

Extracting last query from the prompt line is problematic,
especially with new fzf features such as `--info-command` and
`--input-border`.

Instead we call hide instantly (keeping the perf from the old commit)
and send <esc> to the terminal to execute the esc action and store
the last query using `{q}`.

Closes #1731
@ibhagwan ibhagwan mentioned this issue Jan 19, 2025
Merged
ibhagwan added a commit that referenced this issue Jan 19, 2025
@ibhagwan
fix(hide): better solution for storing last query on esc
fac862c 
This commit partially reverts 85fa30e.

Extracting last query from the prompt line is problematic,
especially with new fzf features such as `--info-command` and
`--input-border`.

Instead we call hide instantly (keeping the perf from the old commit)
and send <esc> to the terminal to execute the esc action and store
the last query using `{q}`.

Closes #1731
ibhagwan added a commit that referenced this issue Jan 19, 2025
@ibhagwan
fix(hide): better solution for storing last query on esc
1dcafcb 
This commit partially reverts 85fa30e.

Extracting last query from the prompt line is problematic,
especially with new fzf features such as `--info-command` and
`--input-border`.

Instead we call hide instantly (keeping the perf from the old commit)
and send <esc> to the terminal to execute the esc action and store
the last query using `{q}`.

Closes #1731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hide): better solution for storing last query on esc ibhagwan/fzf-lua
1 participant
@phanen