Nothing to see here.

[vdegenne]

Is there a way to tell fzf-lua to keep executing the origin call of a picker? I am not sure how to explain so here's what I try to do:

I made this action for when a file is selected:

config.defaults.actions.files["default"] = function(selected, opts)
  local entry = path.entry_to_file(selected[1], opts, opts._uri)

  open_or_focus(entry.path)
end

it will focus the selected file or open it if not found in the windows list. It worked well until I tried to use

require("fzf-lua").lsp_document_symbols({
  regex_filter = symbols_filter
})

I understand now the symbols picker is calling actions.files["default"] action as well, in my case my function will be called and will fail. I could use the uri and line and column information to do everything myself, but I don't want to reinvent the wheel since lsp_document_symbols (and lsp_live_workspace_symbols!) is supposed to do that for me.

It would be good to have a way to tell lsp pickers apart from real file picker.

Or at least a way to tell fzf-lua to disregard a particular execution, e.g.

config.defaults.actions.files["default"] = function(selected, opts)
  local entry = path.entry_to_file(selected[1], opts, opts._uri)

  if opts.__INFO.cmd == "lsp_document_symbols" then
    return false -- Nothing to see here
  end

  open_or_focus(entry.path)
end

Ngl, I'm kinda stuck here and don't know how to fix that.

[ibhagwan]

Maybe I’m missing something but why don’t you use actions.file_switch_or_edit?

fzf-lua/lua/fzf-lua/actions.lua

Line 371 in 175ddbb

M.file_switch_or_edit = function(selected, opts)

[vdegenne]

ok looking at the source code that looks easy to implement:

M.file_switch_or_vsplit = function(selected, opts)
  if not M.file_switch({ selected[1] }, opts) then
    M.file_vsplit({ selected[1] }, opts)
  end
end

Do you think that's something you could add to the plugin (file_switch_or_split and file_switch_or_vsplit)?

If you want I could PR that change.

[ibhagwan]

Do you think that's something you could add to the plugin (file_switch_or_split and file_switch_or_vsplit)?

Given this is so easy to add/customize I really don’t think it’s needed, why don’t you add these few lined to your config instead?

[vdegenne]

Sure I don't mind, it was just to make these directly available to other users.

[ibhagwan]

Sure I don't mind, it was just to make these directly available to other users.

I understand, on the other hand then why not also have file_switch_or_tab also, etc? You see where this is going.

[vdegenne]

Yes right! TBH I'm not even sure if I need that anyways, sometimes simpler things are the best. Thanks again