refactor : Remove potential issues by replacing flushSync and passing ButtonComponents as props directly #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little improvement :
children
:I had to make the Home component "client" to avoid SSR issues.
I removed
getCode
function that usesflushSync
.Instead I wrapped the ChildComponent (Button) into a div and added a
parentRef
reference.So I could target the ChildNode and extract the HTML code as string using
outerHTML
.Node that I forgot to make a separate commit for the formatting caused by my IDE, so that there are a lot of changes due to space and formatting. Sorry about that...
TButton
is just a type for the exported BUTTONS