No mongodb sort and limit in get #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongoid get uses find instead where
unnecessary "return" removed
|
This seems like a good change, in the vein of #33. But your change has caused failures with the CI. Can you make these tests pass please? |
|
@ianwhite sorry, just noticed failures. I suspect it's related to different version of mongoid I'm using locally. I will look into and fix failures soon. |
caching and weird devise bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've replaced where with find in mongoid orm mapper. It removes sorting and limit automatically added by mongoid. Sorting is known to be slow in monogdb world.