docs: convert examples to typescript #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What I've changed:
|
|
Ping @CameronAckermanSEL. |
|
Curious why you’re converting, rather than not just adding TypeScript docs? |
|
Thank you so much for doing all of this work. I'm sorry this took so long for me to get to. |
I saw this converting thing days ago in the issue list. :P |
lukesmurray
pushed a commit
to lukesmurray/slate
that referenced
this pull request
Feb 5, 2021
* docs: convert examples to typescript * docs: convert remaining examples * docs: update next.js * ci: fix lint * docs: fix next.js path * docs: cleanup * update Co-authored-by: wendellhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Not relevant.
What's the new behavior?
Convert all example files to TypeScript and update next.js to 9.4.0.
How does this change work?
Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)Does this fix any issues or need any specific reviewers?
Fixes: #3713
Reviewers: @CameronAckermanSEL