Add a way to completely disable the default placeholder plugin #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to use slate-react, along with a custom placeholder. The problem I'm running into though is that slate-react _always_ adds the PlaceholderPlugin pretty much. Even setting the placeholder to an empty string will still actually add a magic div to the dom, and that's what breaking for me. So, I figured adding support for passing _exactly_ null in to disable the plugin would work well. Folks that don't pass in anything will still get the "default" of an "empty placeholder" so hopefully nothing breaks.
|
fwiw, this is a screenshot of the html of the existing placeholder example. Notice that even though it specifies a custom PlaceholderPlugin, there's still an empty placeholder span added from the default instance of the plugin: |
Closed
|
Fixed by #3093. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use slate-react, along with a custom placeholder.
The problem I'm running into though is that slate-react always adds the PlaceholderPlugin pretty much. Even setting the placeholder to an empty string will still actually add a magic div to the dom, and that's what breaking for me.
So, I figured adding support for passing exactly null in to disable the plugin would work well. Folks that don't pass in anything will still get the "default" of an "empty placeholder" so hopefully nothing breaks.
Is this adding or improving a feature or fixing a bug?
Improving a feature
What's the new behavior?
The placeholder plugin will not be added to the editor if the placeholder prop is exactly null.
How does this change work?
The placeholder plugin will not be added to the editor if the placeholder prop is exactly null.
Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn prettier.)yarn watch.)Does this fix any issues or need any specific reviewers?
Fixes: #
Reviewers: @ianstormtaylor