fix(slate-react/components/content): do not use range.extend on Safari Desktop/iOS #1490
Conversation
…Content ends in whitespace, replace it with unicode no-break space
| @@ -206,7 +207,7 @@ class Content extends React.Component { | |||
| native.removeAllRanges() | |||
|
|
|||
| // COMPAT: IE 11 does not support Selection.extend | |||
| if (native.extend) { | |||
| if ((native.extend && !IS_IOS) && (native.extend && !IS_SAFARI)) { | |||
There was a problem hiding this comment.
Maybe if (native.extend && !(IS_SAFARI || IS_IOS)) for more clarity?
There was a problem hiding this comment.
you are indeed correct! ;)
| @@ -206,7 +207,7 @@ class Content extends React.Component { | |||
| native.removeAllRanges() | |||
|
|
|||
| // COMPAT: IE 11 does not support Selection.extend | |||
There was a problem hiding this comment.
Comment should be updated.
There was a problem hiding this comment.
Great, but also keep the IE-comment about not supporting range.extend please.
|
@zGrav Can you please utdate the title and description of this PR? It is a bit confusing in it's current state. Also I have a feeling it is solving something the wrong way (though it is plausible we don't have anything better to come up with atm). I will have a closer look tomorrow when I have the Safari stack around. |
zGrav
changed the title
zGrav
changed the title
|
ANy update on this PR? I got the same error in Safari |
|
Can anyone verify this? Looking at the support tables it says that |
|
Fixed by #3093. |
…Content ends in whitespace, replace it with unicode no-break space
Fix for #1481