Consistently use toLowerCase in tag name comparisons. #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @schneidmaster, this is great! |
oyeanuj
added a commit
to oyeanuj/slate
that referenced
this pull request
Aug 25, 2017
* ianstormtaylor/master: (21 commits) 0.21.3 Add .babelrc into .npmignore (ianstormtaylor#1020) Add a missing dependency which was causing errors (ianstormtaylor#1017) Fixes ianstormtaylor#1010 — adds debuginfo to Contributing.md (ianstormtaylor#1011) Add State.characters to docs (ianstormtaylor#1006) Use parent node to find text node parent (ianstormtaylor#1004) IE11 compat (ianstormtaylor#996) Add .editorconfig and .gitattributes (ianstormtaylor#997) Improve documentation (ianstormtaylor#1000) Consistently use toLowerCase in tag name comparisons. (ianstormtaylor#1001) Custom wrapper component (ianstormtaylor#978) Add link to IME reference page in Contributing.md (ianstormtaylor#995) Don't break macOS emoji insert nor composition when fixing ianstormtaylor#938 (ianstormtaylor#994) When the `isInEditor` parameter is a text node use its parent only if the parent exists (ianstormtaylor#974) Document Raw serializer options (ianstormtaylor#993) tagName returns capitalized name now (ianstormtaylor#985) Fixes ianstormtaylor#938 chrome eating first line of text on space at beginning of line (ianstormtaylor#991) Fixes ianstormtaylor#817; fragment matcher regex (ianstormtaylor#992) Update ISSUE_TEMPLATE.md Update Contributing.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use the native
DOMParserfor HTML deserialization in browser environments, while recommendingparse5for server-side rendering or node environments. TheDOMParserimplements the DOM spec which returns uppercase tag names, whileparse5implements the more low-level HTML spec and ends up returning lowercase tag names (it's a little more nuanced but that's the TL;DR, see this issue for the full discussion). Because of this discrepancy, for the time being we should consistently use & recommend case-insensitive comparisons of tag names to prevent potential environment-specific bugs and confusion. (Currently we useDOMParser-compatible CAPS tags in some documentation/examples while usingtoLowerCaseelsewhere.)