Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect GIR for appstream.SearchTokenMatch #47

Open
ianprime0509 opened this issue Feb 13, 2024 · 1 comment
Open

Incorrect GIR for appstream.SearchTokenMatch #47

ianprime0509 opened this issue Feb 13, 2024 · 1 comment
Labels
gir The issue is related to GIR files upstream The issue resides upstream

Comments

@ianprime0509
Copy link
Owner

ianprime0509 commented Feb 13, 2024 •
edited
Loading

This is a bit field where the underlying C type is a packed enum. The packed nature of the enum is not currently representable in GIR; currently, it is fixed using a custom extension (bits attribute on enum and bit field types).
@ianprime0509 ianprime0509 added upstream The issue resides upstream gir The issue is related to GIR files labels Feb 13, 2024
ianprime0509 added a commit that referenced this issue Feb 13, 2024
@ianprime0509
fix: use correct size for appstream.SearchTokenMatch
7c8eb99 
Works around #47
Closes #40

This commit introduces an extension to GIR, the attribute `bits` on
enums and bit fields, to handle packed enums. A fix is also applied to
the AppStream GIR to use this extension to fix the translation of
`appstream.SearchTokenMatch`.
@ianprime0509
Copy link
Owner Author

Evidently this was removed from the public API a year ago: ximion/appstream@eebb0f8 The GNOME 47 SDK no longer contains a version with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gir The issue is related to GIR files upstream The issue resides upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianprime0509