Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support @ prefixes #759

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Sep 22, 2023

Description:

Adds support for @ prefix on TODOs ala the old JavaDoc style.

e.g.

/**
 * @todo: foo
 */

Related Issues:

Fixes #516

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
@ianlewis ianlewis linked an issue Sep 22, 2023 that may be closed by this pull request
@ianlewis ianlewis changed the title 516 feature support todo javadoc comments feat: Support @ prefixes Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #759 (a323f4a) into main (ce98583) will increase coverage by 0.48%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   80.50%   80.99%   +0.48%     
==========================================
  Files          19       18       -1     
  Lines        1144     1126      -18     
  Branches       14       14              
==========================================
- Hits          921      912       -9     
+ Misses        160      154       -6     
+ Partials       63       60       -3     
Files Changed Coverage Δ
internal/todos/todos.go 99.16% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ianlewis ianlewis marked this pull request as ready for review September 22, 2023 12:21
@ianlewis ianlewis merged commit 3f14b78 into main Sep 22, 2023
32 of 33 checks passed
@ianlewis ianlewis deleted the 516-feature-support-todo-javadoc-comments branch September 22, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support "@todo" JavaDoc comments
1 participant