Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for TODOs in JavaDoc #579

Merged

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Sep 4, 2023

Description:

Add support for JavaDoc/JSDoc/TSDoc comments that have a leading asterisk.

/**
 * Some comment.
 * TODO: Add some code here.
 */

Related Issues:

Fixes #517

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Signed-off-by: Ian Lewis <[email protected]>
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #579 (d6569e9) into main (cc90c56) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   80.46%   80.48%   +0.01%     
==========================================
  Files          19       19              
  Lines        1121     1122       +1     
  Branches       14       14              
==========================================
+ Hits          902      903       +1     
  Misses        157      157              
  Partials       62       62              
Files Changed Coverage Δ
internal/todos/todos.go 100.00% <100.00%> (ø)

@ianlewis ianlewis marked this pull request as ready for review September 4, 2023 02:00
@ianlewis ianlewis changed the title 517 bug todos arent being picked up from javadoc comments feat: Add support for TODOs in JavaDoc Sep 4, 2023
Signed-off-by: Ian Lewis <[email protected]>
@ianlewis ianlewis merged commit 88d5366 into main Sep 4, 2023
@ianlewis ianlewis deleted the 517-bug-todos-arent-being-picked-up-from-javadoc-comments branch September 4, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] TODOs aren't being picked up from JavaDoc comments
1 participant