Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for looser TODO special case #537

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Sep 3, 2023

Description:

Adds support for a special case of TODO comments with no whitespace between the comment start and "TODO" and with no delimiter between "TODO" and the message.

//TODO This is a todo comment.

Related Issues:

Fixes #514

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • A reference to a related issue in the repository.
  • A description of the changes proposed in the pull request.
  • Please make sure to sign the Google CLA.
  • Please make sure your commits include a Developer Certificate of Origin signoff.
  • Please add unit tests

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #537 (dbefef4) into main (5c4ac57) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   80.27%   80.46%   +0.19%     
==========================================
  Files          19       19              
  Lines        1110     1121      +11     
  Branches       14       14              
==========================================
+ Hits          891      902      +11     
  Misses        157      157              
  Partials       62       62              
Files Changed Coverage Δ
internal/todos/todos.go 100.00% <100.00%> (ø)

@ianlewis ianlewis changed the title Add support for looser TODO special case feat: Add support for looser TODO special case Sep 3, 2023
Signed-off-by: Ian Lewis <[email protected]>
@ianlewis ianlewis marked this pull request as ready for review September 3, 2023 23:25
@ianlewis ianlewis merged commit f02bf24 into main Sep 3, 2023
@ianlewis ianlewis deleted the 514-feature-support-todo-comments branch September 3, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support "//TODO" comments
1 participant