Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Elixir moduledoc support #1548

Merged
merged 3 commits into from
Aug 26, 2024
Merged

feat: Add Elixir moduledoc support #1548

merged 3 commits into from
Aug 26, 2024

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Aug 26, 2024

Description:

Add Elixir moduledoc support and refactors the LanguageConfig to reuse some config. Adds support for multiple multi-line comment configurations per language.

Related Issues:

Fixes: #1546

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Refactors the LanguageConfig to reuse some config. Adds support for
multiple multi-line comment configurations per language.

Fixes: #1546

Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
@ianlewis ianlewis marked this pull request as ready for review August 26, 2024 02:36
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.07%. Comparing base (6449e88) to head (32bfe4b).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/scanner/scanner.go 93.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1548      +/-   ##
==========================================
+ Coverage   75.85%   76.07%   +0.22%     
==========================================
  Files          17       17              
  Lines        1147     1158      +11     
==========================================
+ Hits          870      881      +11     
  Misses        201      201              
  Partials       76       76              
Files Coverage Δ
internal/scanner/state.go 0.00% <ø> (ø)
internal/todos/todos.go 99.20% <100.00%> (+0.02%) ⬆️
internal/scanner/scanner.go 71.68% <93.33%> (+0.60%) ⬆️

@ianlewis ianlewis merged commit 9981a36 into main Aug 26, 2024
15 checks passed
@ianlewis ianlewis deleted the languages-refactor branch August 26, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support Elixir moduledoc
1 participant