Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude-dir not matching with path separator #1465

Merged

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Feb 21, 2024

Description:

--exclude-dir now ignores trailing path separators on the directory name passed to it. This is since it's natural to pass something like mydir/ as a directory name.

Related Issues:

Fixes #1463

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

`--exclude-dir` now ignores trailing path separators on the directory
name passed to it. This is since it's natural to pass something like
`mydir/` as a directory name.

Fixes #1463

Signed-off-by: Ian Lewis <[email protected]>
@ianlewis ianlewis linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95753d7) 79.16% compared to head (3abda3f) 79.16%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1465   +/-   ##
=======================================
  Coverage   79.16%   79.16%           
=======================================
  Files          15       15           
  Lines         907      907           
=======================================
  Hits          718      718           
  Misses        138      138           
  Partials       51       51           
Files Coverage Δ
internal/cmd/todos/app.go 85.77% <100.00%> (ø)

@ianlewis ianlewis merged commit 3180bc5 into main Feb 21, 2024
14 checks passed
@ianlewis ianlewis deleted the 1463-bug-exclude-dir-does-not-exclude-directory-with-at-the-end branch February 21, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] --exclude-dir does not exclude directory with / at the end
1 participant