Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add -s -w ldflags to release #1218

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Dec 5, 2023

Description:

Add -s -w ldflags to SLSA builder config so that release binaries have debug symbols stripped. This results in smaller binaries.

Related Issues:

Fixes #1082

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

@ianlewis ianlewis linked an issue Dec 5, 2023 that may be closed by this pull request
@ianlewis ianlewis marked this pull request as ready for review December 5, 2023 07:26
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #1218 (8b12d90) into main (42124ba) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          19       19           
  Lines        1078     1078           
  Branches       17       17           
=======================================
  Hits          885      885           
  Misses        140      140           
  Partials       53       53           

@ianlewis ianlewis merged commit ff5353c into main Dec 5, 2023
35 checks passed
@ianlewis ianlewis deleted the 1082-ci-add-s-w-ldflags-to-release branch December 5, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] Add '-s -w' ldflags to release
1 participant