Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing early when we cannot find symbols on macho #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkonolige
Copy link

I've been hitting this issue on macOS where backtrace errors out early even though it can still find symbols for some libraries. This happens when I am loading my library dynamically from python, so I assume its some python libraries that are causing issues.

I'm not quite sure if the logic here is correct. It works in my use cases, but I think I need someone who knows the codebase to verify it is correct.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed label Dec 16, 2020
@tkonolige
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed and removed cla: no CLA not signed labels Dec 16, 2020
@tkonolige
Copy link
Author

@ianlancetaylor Could you take a look at this. Its a pretty simple fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants