Update make_string util to clean up bad values #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From exif-samples-master, the type of the seq arguments for a few entries (mostly UserComment) in util.make_string is a list. mypy still succeeds after the type annotation amendment. There is also no value in keeping a list of null bytes.
On another note, many other UserComment only contain spaces and some other fields contained trailing spaces (seen null character as well).
Finally, Nikon MakerNote ISOSetting is int16u[2] and should not be stringified. https://exiftool.org/TagNames/Nikon.html Sample values seen include [0, 0] and [0, 200], which were respectively being converted to '[0, 0]' and '}' by make_string.
The test diff output does not clearly show the effect of
.strip()
, so here it is along one example of the printable value of the IfdTag:@ianare, if you approve this PR, I can modify the exif-sample-master/dump afterwards to reflect changes :)
🐍 🤹♂️