This repository has been archived by the owner on Dec 10, 2017. It is now read-only.
Refactored capsule server and fixed bug #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicate code for capsule_zmq and capsule_mpc, now both are operating from capsule_server. The capsule_server/local_server.py script now accepts two flags, one for the type of tasks that it handles (mpc or zmq) and the port. Capsule server now sends pickled dictionary responses that contain a 'success' flag. When success is false, an exception is thrown at the client side. On the capsule client, exception handling for the new 'protocol' is done in an unobtrusive way, by means of the TaskSocket class that wraps zmq.socket. Changed build_and_run.sh script to reflect these changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #26.
Removed duplicate code for capsule_zmq and capsule_mpc, now both are operating from capsule_server.
The capsule_server/local_server.py script now accepts two flags, one for the type of tasks that it handles
(mpc or zmq) and the port.
Capsule server now sends pickled dictionary responses that contain a 'success' flag. When success is false,
an exception is thrown at the client side.
On the capsule client, exception handling for the new 'protocol' is done in an unobtrusive way, by means of
the TaskSocket class that wraps zmq.socket.
Changed build_and_run.sh script to reflect these changes.