added remove all tags function "removeAllTags()" this will resolve th…

…e issue "Remove all tags/Reinitialize maxwells#31" Can be view in demo3.html
iamsalmanafzal · Apr 27, 2017 · 9ca61e6 · 9ca61e6
1 parent 5e82a9c
commit 9ca61e6
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -101,6 +101,7 @@ function | return type | description
 `addTag(tag:string)` | `Tagger` | add a tag
 `renameTag(tag:string, newTag:string)` | `Tagger` | rename one tag to another value
 `removeLastTag()` | `Tagger` | removes last tag if it exists
+`removeAllTags()` | `Tagger` | removes all tags
 `removeTag(tag:string)` | `Tagger` | removes tag specified by string if it exists
 `addTagWithContent(tag:string, popoverContent:string)` | `Tagger` | Add a tag with associated popover content
 `setPopover(tag:string, popoverContent:string)` | `Tagger` | update a tag's associated popover content, if that tag exists

diff --git a/demo-3.html b/demo-3.html
@@ -76,7 +76,7 @@ <h3>Bootstrap 3.0.3</h3>
             });
 
             $('#removeAllTags').click(function(){
-              newTagsInialized.smallTags.removeAllTag();
+              newTagsInialized.smallTags.removeAllTags();
             });
           });
         </script>

diff --git a/dist/js/bootstrap-tags.js b/dist/js/bootstrap-tags.js
@@ -102,7 +102,7 @@
                 };
                 this.removeTagClicked = function(e) {
                     if (e.currentTarget.tagName === "A") {
-                        _this.removeTag($("span", e.currentTarget.parentElement).html());
+                        _this.removeTag($("span", e.currentTarget.parentElement).text());
                         $(e.currentTarget.parentNode).remove();
                     }
                     return _this;
@@ -116,9 +116,8 @@
                     }
                     return _this;
                 };
-                this.removeAllTag = function() {
+                this.removeAllTags = function() {
                     if (_this.tagsArray.length > 0) {
-                        var arrayLength = _this.tagsArray.length
                         _this.tagsArray = [];
                         _this.renderTags();
                         if (_this.canAddByMaxNum()) {
@@ -201,7 +200,7 @@
                         e.preventDefault();
                         _this.pressedReturn(e);
                         tag = e.target.value;
-                        if (_this.suggestedIndex !== -1) {
+                        if (_this.suggestedIndex != null && _this.suggestedIndex !== -1) {
                             tag = _this.suggestionList[_this.suggestedIndex];
                         }
                         _this.addTag(tag);
@@ -458,7 +457,7 @@
                         this.removeTag = function() {};
                         this.removeTagClicked = function() {};
                         this.removeLastTag = function() {};
-                        this.removeAllTag = function() {};
+                        this.removeAllTags = function() {};
                         this.addTag = function() {};
                         this.addTagWithContent = function() {};
                         this.renameTag = function() {};

diff --git a/dist/js/bootstrap-tags.min.js b/dist/js/bootstrap-tags.min.js
diff --git a/spec/bootstrap-tags-spec.js b/spec/bootstrap-tags-spec.js
@@ -83,6 +83,17 @@
         });
       });
     });
+    describe("when the enter key is pressed before any text is entered", function() {
+      beforeEach(function() {
+        this.tags = newTagger("tagger2", {});
+        return $('#tagger2 .tags-input').trigger($.Event('keydown', {
+          which: 13
+        }));
+      });
+      return it("does not add any tags", function() {
+        return expect(this.tags.getTags()).toEqual([]);
+      });
+    });
     return describe("when normally operating", function() {
       beforeEach(function() {
         this.initTagData = ['one', 'two', 'three'];

diff --git a/src/bootstrap-tags.coffee b/src/bootstrap-tags.coffee
@@ -106,6 +106,14 @@ jQuery ->
         @enableInput() if @canAddByMaxNum()
       @
 
+    # removeAllTags removes All tags.
+    @removeAllTags = => 
+      if @tagsArray.length > 0
+        @tagsArray = []
+        @renderTags()
+        @enableInput() if @canAddByMaxNum()
+      @
+
     # removeTag removes specified tag.
     # - Helper method for removeTagClicked and removeLast Tag
     # - also an exposed method (can be called from page javascript)
@@ -404,6 +412,7 @@ jQuery ->
         @removeTag = ->
         @removeTagClicked = ->
         @removeLastTag = ->
+        @removeAllTags = ->
         @addTag = ->
         @addTagWithContent = ->
         @renameTag = ->