Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update he locale for double units #1287

Merged
merged 4 commits into from
Dec 27, 2020
Merged

fix: update he locale for double units #1287

merged 4 commits into from
Dec 27, 2020

Conversation

zvizvi
Copy link
Contributor

@zvizvi zvizvi commented Dec 23, 2020

Better Hebrew localization

@iamkun
Copy link
Owner

iamkun commented Dec 24, 2020

Thanks.

Would you like to add some test,s please? like https://github.com/iamkun/dayjs/blob/dev/test/locale/hu.test.js#L29

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #1287 (23601e4) into dev (0e7ff3d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1287   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          174       174           
  Lines         1669      1672    +3     
  Branches       381       382    +1     
=========================================
+ Hits          1669      1672    +3     
Impacted Files Coverage Δ
src/locale/he.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7ff3d...23601e4. Read the comment docs.

@iamkun iamkun merged commit 1c4b0da into iamkun:dev Dec 27, 2020
iamkun pushed a commit that referenced this pull request Dec 27, 2020
## [1.9.8](v1.9.7...v1.9.8) (2020-12-27)

### Bug Fixes

* fix Ukrainian [uk] locale typo ([1605cc0](1605cc0))
* update Hebrew [he] locale for double units ([#1287](#1287)) ([1c4b0da](1c4b0da))
* update zh locale meridiem "noon" ([0e7ff3d](0e7ff3d))
* update zh-cn locale definition of noon  ([#1278](#1278)) ([d5930b9](d5930b9))
@iamkun
Copy link
Owner

iamkun commented Dec 27, 2020

🎉 This PR is included in version 1.9.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.9.8](iamkun/dayjs@v1.9.7...v1.9.8) (2020-12-27)

### Bug Fixes

* fix Ukrainian [uk] locale typo ([1605cc0](iamkun/dayjs@1605cc0))
* update Hebrew [he] locale for double units ([#1287](iamkun/dayjs#1287)) ([1c4b0da](iamkun/dayjs@1c4b0da))
* update zh locale meridiem "noon" ([0e7ff3d](iamkun/dayjs@0e7ff3d))
* update zh-cn locale definition of noon  ([#1278](iamkun/dayjs#1278)) ([d5930b9](iamkun/dayjs@d5930b9))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.9.8](iamkun/dayjs@v1.9.7...v1.9.8) (2020-12-27)

### Bug Fixes

* fix Ukrainian [uk] locale typo ([1605cc0](iamkun/dayjs@1605cc0))
* update Hebrew [he] locale for double units ([#1287](iamkun/dayjs#1287)) ([1c4b0da](iamkun/dayjs@1c4b0da))
* update zh locale meridiem "noon" ([0e7ff3d](iamkun/dayjs@0e7ff3d))
* update zh-cn locale definition of noon  ([#1278](iamkun/dayjs#1278)) ([d5930b9](iamkun/dayjs@d5930b9))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
## [1.9.8](iamkun/dayjs@v1.9.7...v1.9.8) (2020-12-27)

### Bug Fixes

* fix Ukrainian [uk] locale typo ([1605cc0](iamkun/dayjs@1605cc0))
* update Hebrew [he] locale for double units ([#1287](iamkun/dayjs#1287)) ([1c4b0da](iamkun/dayjs@1c4b0da))
* update zh locale meridiem "noon" ([0e7ff3d](iamkun/dayjs@0e7ff3d))
* update zh-cn locale definition of noon  ([#1278](iamkun/dayjs#1278)) ([d5930b9](iamkun/dayjs@d5930b9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants