Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zh not being loaded #35

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Fix zh not being loaded #35

merged 1 commit into from
Jun 8, 2021

Conversation

ahdg6
Copy link
Contributor

@ahdg6 ahdg6 commented Jun 8, 2021

No description provided.

@iamgio iamgio merged commit 16cb86a into iamgio:master Jun 8, 2021
iamgio added a commit that referenced this pull request Jun 8, 2021
@iamgio
Use zhCN instead of zh-Hans (#35)
4e14f14
@iamgio
Copy link
Owner

iamgio commented Jun 8, 2021 •
edited
Loading

It turned out zhCN was absolutely fine, the problem was that the Lang enum used to define the zhcn tag, while the resource bundle was using zhCN. It worked well when started from the IDE but not from the generated JAR, I don't know why.
Edit: I will be releasing a hotfix soon.

@iamgio
Copy link
Owner

iamgio commented Jun 10, 2021

I just released 1.3.2, now it should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahdg6 @iamgio