Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #150: check for documentElement instead of body #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dvdrhr
Copy link

@dvdrhr dvdrhr commented Feb 13, 2020

#150

works for me, tested in chrome, safari, edge, mobile chrome and mobile safari

@jeremenichelli
Copy link
Collaborator

jeremenichelli commented Feb 15, 2020

Thanks for the PR first of all.

I think this one is missing a couple of edge cases for example when an element forces the window plus its scrollable container to scroll, d.body is referenced in other cases. I'd recommend running your local build in the repository page to test each case.

I will try to take a further look to try to detect edge cases. But the change is pointing into the right direct and it does solve your reported case in the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants