Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve cjs global mock issue #220

Merged
merged 1 commit into from
Jul 30, 2023
Merged

resolve cjs global mock issue #220

merged 1 commit into from
Jul 30, 2023

Conversation

iambumblehead
Copy link
Owner

@iambumblehead iambumblehead commented Jul 30, 2023 •
edited
Loading

resolves #218

@iambumblehead
Copy link
Owner Author

@tommy-mitchell please review

@iambumblehead
Copy link
Owner Author

changes here seem safe to deploy, let's deploy and any suggestions can be applied later in a follow up MR

@iambumblehead iambumblehead merged commit c8076f4 into master Jul 30, 2023
@iambumblehead iambumblehead deleted the resolve-cjs-global-mock branch July 30, 2023 21:27
@koshic koshic mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommy-mitchell tommy-mitchell Awaiting requested review from tommy-mitchell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using import key with modules that have CJS imports
2 participants
@iambumblehead @bumblehead