Detect async resolve #201
Merged
Detect async resolve #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the "catch" part that calls resolvewithplus was added because v18 windows latest did not resolve this path correctly. that error can still be seen here here https://github.com/iambumblehead/esmock/actions/runs/4900110355/jobs/8750542283?pr=201 the paths look fine to me |
|
@koshic you seem to be away, let's merge now and handle any concerns in a follow up mr |
|
@iambumblehead thx! It looks totally ok for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #200
@koshic please review if available