Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to drape the background map onto reality meshes. #7401

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MarcNeely
Copy link
Contributor

@MarcNeely MarcNeely commented Nov 19, 2024

This ability already somewhat existed. This PR simply exposes it more so that context reality models which are meshes as well as other reality models which are meshes can have the background map draped onto them as well at will. This is done by adding a RealityMeshDisplaySettings member to the RealityModelDisplaySettings class.

This is a partial fix for issue #6214

@MarcNeely
Copy link
Contributor Author

@pmconne Paul, the change I'm wondering about is in RealityModelTileTree:addToScene. Currently the display setting for the draping cannot turn off the draping if it is set in the model tile data with the doDrapeBackgroundMap flag. I'm actually not sure how we would tell that they wanted it to override it anyhow since the bgMapDrape flag is off by default in the RealityMeshDisplaySettings unless we change this from a boolean to an enum and provide a third option for overriding what the tiles say.

@pmconne
Copy link
Member

pmconne commented Nov 19, 2024

@MarcNeely the flag on the tileset indicates a rare, legacy scalable mesh export whose texture imagery comes from a map service instead of being baked in to the tiles. To me, that seems orthogonal to your new RealityMeshDisplaySettings flag that controls whether or not we replace the tileset's texture imagery with map imagery. Kinda like how overriding an element's color to blue would have no visible effect if the element is already intrinsically blue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants