New schema locater to locate the standard schemas delivered as part of the core-backend package #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fee9279.
…hub.com/iTwin/itwinjs-core into rohitptnkr/backend-schemas-file-locater
RohitPtnkr1996
requested review from
a team,
ColinKerr,
christophermlawson and
StefanApfel-Bentley
as code owners
pmconne
approved these changes
Nov 26, 2024
aruniverse
reviewed
Nov 26, 2024
| * @beta This is a workaround the current lack of a full xml parser. | ||
| */ | ||
| export class PublishedSchemaJsonFileLocater extends SchemaJsonFileLocater implements ISchemaLocater { | ||
| public static defaultSchemaSearchPaths = new Set([ |
There was a problem hiding this comment.
this seems to be repeated a few times, wonder if we extract this out to a var that is referenced everywhere
what happens today if you update one of these places but not the others?
having a list of these schemas grouped is helpful, but if its not needed you could use a glob to pull in all schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6145