Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump vitest dependencies #7340

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Bump vitest dependencies #7340

wants to merge 10 commits into from

Conversation

hl662
Copy link
Contributor

@hl662 hl662 commented Nov 8, 2024 •
edited
Loading

  • Consume 2.1.5 for vitest related dependencies
  • All vitest deps follow the same version number, to avoid dependency mismatch warnings when running tests.

@hl662 hl662 self-assigned this Nov 8, 2024
@hl662 hl662 requested review from a team as code owners November 8, 2024 16:44
aruniverse
aruniverse approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't rush catch this?

@hl662
Copy link
Contributor Author

hl662 commented Nov 8, 2024

Why didn't rush catch this?

The mismatched dependencies were in the pnpm lockfile. Some were '2.1.1', while others were '2.1.0'. I guess rush doesn't catch mismatched deps that are in lockfiles

@hl662
Copy link
Contributor Author

hl662 commented Nov 13, 2024

setting back to draft for now, circling back to fix regression for vitest/browser at a later point

@hl662 hl662 marked this pull request as draft November 13, 2024 19:59
@hl662 hl662 marked this pull request as ready for review November 15, 2024 22:18
@hl662
Copy link
Contributor Author

hl662 commented Nov 15, 2024

Marked as active again - I had to update the setup file for core frontend to import the barrel file. Vitest now inlines setup files into test files , messing up dependency resolution in test files and reintroducing circular imports otherwise

@hl662 hl662 enabled auto-merge (squash) November 15, 2024 22:21
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2024

This pull request is now in conflicts. Could you fix it @hl662? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@hl662 hl662 marked this pull request as draft November 20, 2024 18:43
auto-merge was automatically disabled November 20, 2024 18:43

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse approved these changes

@DStradley DStradley Awaiting requested review from DStradley DStradley is a code owner automatically assigned from iTwin/itwinjs-core

@MichaelSwigerAtBentley MichaelSwigerAtBentley Awaiting requested review from MichaelSwigerAtBentley MichaelSwigerAtBentley is a code owner automatically assigned from iTwin/itwinjs-core

@MBudreviciusBentley MBudreviciusBentley Awaiting requested review from MBudreviciusBentley MBudreviciusBentley is a code owner automatically assigned from iTwin/itwinjs-core

@bbastings bbastings Awaiting requested review from bbastings bbastings is a code owner

@ben-polinsky ben-polinsky Awaiting requested review from ben-polinsky ben-polinsky is a code owner

Assignees

@hl662 hl662

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hl662 @aruniverse