Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IDisposable and related utilities #7309

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Conversation

wgoehrig
Copy link
Member

Since TypeScript 5.2 added support for the explicit resource management feature in ECMAScript, let's deprecate IDisposable and use the new built-in Disposable instead.

@pmconne
Copy link
Member

pmconne commented Oct 31, 2024

I want to see what output the linter produces. You've presumably introduced a ton of deprecation warnings.

I'd remove all the implements IDisposables from our code - they all implicitly implement it and you'd otherwise presumably have to suppress the lint rule at each occurrence.

@wgoehrig
Copy link
Member Author

This is actually passing lint without any errors in its current state - looks like the @typescript-eslint/no-deprecated rule just doesn't check implements clauses...

@pmconne
Copy link
Member

pmconne commented Oct 31, 2024

I'd remove implements IDisposable everywhere anyway, no reason to document implementation of an interface we discourage people from using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants