Fix point cloud jitter and quantization issues for additive refinement pnts #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ImageTests ran and the only differences were considered inconsequential ones from now supporting unquantized pnts data. |
pmconne
reviewed
Apr 7, 2023
pmconne
reviewed
Apr 7, 2023
pmconne
approved these changes
Apr 7, 2023
The error is telling you what you need to do to fix it. |
|
I did "npm run extract-api" in the core\extension folder (step 1), and it generated no modified files anywhere, so can't do step 2. |
|
Don't know what to do about the repeatable MacOS security error. |
As yet there is no fix available. Nothing to do with your changes. |
|
@Mergifyio backport release/3.7.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
…t pnts (#5324) Co-authored-by: Paul Connelly <[email protected]> (cherry picked from commit 7de7e53)
aruniverse
added a commit
that referenced
this pull request
Apr 19, 2023
…t pnts (backport #5324) [release/3.7.x] (#5421) Co-authored-by: DStradley <[email protected]> Co-authored-by: Arun George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5333
Investigating problems with a user point cloud showed jitter and gaps in the displayed data, both indicating quantization issues. The point cloud was PNTS format, but using additive refinement. Also, the first 13 pnts files were unquantized, but all the rest were quantized.
Found that we were quantizing the unquantized tiles, so first changed that to generate and use unquantized point cloud graphics (for PNTS), but that by itself did not solve the problem. Investigating further, I found that the RTC_CENTER in these tiles was large enough to cause quantization issues the way it was added into the vertex shader points. I removed that offset from the vertex shader points, then added it into a transform for the tile instead, and that resolved the problem.
Had to adjust batch range by RTC_CENTER since it is in the transform now (for locate, etc.). Also had to create a range for unquantized points for the voxelSize calculation, since the qParam range (scale of 1) would not work for that.
TODO