Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong terrain tiles #2486

Closed
jailln opened this issue Jan 17, 2025 · 1 comment · Fixed by #2491
Closed

Wrong terrain tiles #2486

jailln opened this issue Jan 17, 2025 · 1 comment · Fixed by #2491
Assignees
Labels

Comments

@jailln
Copy link
Contributor

jailln commented Jan 17, 2025

Context

Terrain tiles have been refactored in #2440. Since then, they have a point with altitude 0.
Also, it seems that the skirt is no longer working.

Steps to Reproduce

Open any globe example and toggle wireframe mode in the debug menu

Expected Behavior

Before the PR, without terrain:

Image

and with terrain:

Image

Actual Behavior

Currently on master, without terrain:

Image

and with terrain:

Image

The broken skirt:

Image

@HoloTheDrunk
Copy link
Contributor

I had painstakingly found and squashed what feels like this exact bug while working on the PR, but that change got crushed in the squash... Fixing this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants