Fix bugs #128 and #129 in Stations.php #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dashes and spaces are correctly sanitized #128
…owed by partial matches #129
|
This is a neat PR! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #128 fixed: Dashes and spaces are correctly sanitized
Bug #129 fixed: When an exact match is found, the exact match will be at index 0 in the array. Partial matches can be found in the next indices.
This PR includes fixes for both issues, tests to ensure these issues won't occur again, and general improvements to readability and remove code duplication by moving 2 complex if-statements to their own function.
PHPUnit might fail on a broken dependency for PHP 7.2:
lanthaler/JsonLD#88
lanthaler/JsonLD#92