-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove killswitch #9856
Remove killswitch #9856
Conversation
@DzikuVx Having the ability to set this function to OFF, is rather useful. By not allowing the FC to disarm unless the throttle is low. I know some may say that if you lower the throttle later it will disarm anyway.. But maybe not many kilometers away. |
Though I completely agree with removing this. It may be worth waiting until the VTX is kept high power in the emergency rearm period. I’m hoping this will be in 8.0. But my initial tests the MSP didn’t obey keeping the arming state as armed (#9688) |
@Jetrell KILLSWITCH removal is not connected with the state of VTX and should be considered as separate elements. What KILLSWITCH was doing was disarming just like regular disarm with the switch. VTX high power after disarm can be implemented separately from this change |
Additionally @Jetrell disarm regardless of THR value is a thing for a few years. I think you might have mistaken the KILLSWITCH mode with "disarm in any throttle aka killswitch". Those are 2 completely different things and the later one was removed years ago |
That's fine if its not.. I was just going off what was written in the Doc Update commit. It seemed to indicate it was the disarm kill switch ? |
ok, you are right. I will make adjustments tonthe code |
As a bonus we get rid of not neede
MSP_ARMING_CONFIG
andMSP_SET_ARMING_CONFIG
MSP frames