Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove killswitch #9856

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Remove killswitch #9856

merged 5 commits into from
Mar 29, 2024

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented Mar 25, 2024

As a bonus we get rid of not neede MSP_ARMING_CONFIG and MSP_SET_ARMING_CONFIG MSP frames

@DzikuVx DzikuVx added this to the 8.0 milestone Mar 26, 2024
@Jetrell
Copy link

Jetrell commented Mar 28, 2024

@DzikuVx Having the ability to set this function to OFF, is rather useful. By not allowing the FC to disarm unless the throttle is low.
The reason being. Is because if the pilot accidentally disarms his plane at a distance. The HD VTX's will fall back to standby power, loosing the video link. And the HD DVR will stop recording.

I know some may say that if you lower the throttle later it will disarm anyway.. But maybe not many kilometers away.
There is a way I work around this. Its by having a audio siren on the radio go off if the FC is disarm when the telemetry is showing the GPS speed is over 20km/h.. This informs you of an accidental disarm.

@MrD-RC
Copy link
Collaborator

MrD-RC commented Mar 28, 2024

Though I completely agree with removing this. It may be worth waiting until the VTX is kept high power in the emergency rearm period. I’m hoping this will be in 8.0. But my initial tests the MSP didn’t obey keeping the arming state as armed (#9688)

@DzikuVx
Copy link
Member Author

DzikuVx commented Mar 28, 2024

@Jetrell KILLSWITCH removal is not connected with the state of VTX and should be considered as separate elements. What KILLSWITCH was doing was disarming just like regular disarm with the switch.

VTX high power after disarm can be implemented separately from this change

@DzikuVx
Copy link
Member Author

DzikuVx commented Mar 28, 2024

Additionally @Jetrell disarm regardless of THR value is a thing for a few years. I think you might have mistaken the KILLSWITCH mode with "disarm in any throttle aka killswitch". Those are 2 completely different things and the later one was removed years ago

@Jetrell
Copy link

Jetrell commented Mar 28, 2024

Additionally disarm regardless of THR value is a thing for a few years. I think you might have mistaken the KILLSWITCH mode with "disarm in any throttle aka killswitch". Those are 2 completely different things and the later one was removed years ago

That's fine if its not.. I was just going off what was written in the Doc Update commit. It seemed to indicate it was the disarm kill switch ?

daks

@DzikuVx
Copy link
Member Author

DzikuVx commented Mar 29, 2024

ok, you are right. I will make adjustments tonthe code

@DzikuVx DzikuVx merged commit 2612c13 into master Mar 29, 2024
16 checks passed
@DzikuVx DzikuVx deleted the dzikuvx-remove-killswitch branch March 29, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants