[GPS] Fix message rate for newer ublox devices and add some extra debugging features #10179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a bonus: Add gpssats and showdebug cli commmands.
|
As a bonus, also add showdebug cli command: |
mmosca
changed the title
Provide alternative way of setting message rates in case firmware is too old. Try to enable NAV_SIG but fallback to NAV_SAT. TODO: fill nav sat info into satelites Current status of GPS debug counters 0: NAV_SIG count 1: MSG_PVT count 2: MSG_SAT count 3: 4: 5: flags.pvt 6: flags.sat 7: flags.sig
|
M8 does not support NAV_SIG. So I will add NAV_SAT as a fallback and try to make the setup more resilient to random hardware / software combinations. |
2 cases: Firmware newer than 23.01 => has pvt and new setting message Everything else = legacy. (Including M8)
1) New api, nav_pvt and nav_sig (m9+) 2) Old api, nav_pvt and nav_sat (m7?/m8) 3) Old api, no nav_pvt or nav_sat (time to upgrade)
|
Current showdebug items for debug_mode = GPS |
|
Some older devices: c. 2016/7 M8 (0.5MB, v2 firmware)From
|
|
Cool. Very useful. I will have a loot. I am not 100% sure I am parsing all the satelite fields correctly, specially coming from older messages. The one that didn't read the version, probably needs initializing of the satelites array to get rid of false entries. |
The older model only has SW and HW version strings, no extended version with the protocol version. |
I should have fixed the reporting now. Can you check if there are any regressions on m8 hardware? I may eventually add some of this info to the configurator as well |
Old M8 (v2 firmware).InfoCLI
|
|
I have a plan for that. the 64 is an arbitrary number I picked. Can easily be changed. Regarding m6, I do have a plan for that. There are currently 3 main categories of gps in the ublox code:
I was planning on suggesting deprecating anything before 15.01 You may be bale to use use it, but we will drop the auto config and you need to make sure it can output NAV_PVT and NAV_SIT or NAV_SAT. Lots of code we can remove in that case |
Add warning about ublox protocol version < 15.00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UBLOX and UBLOX7 are now the same thing.
Fix the message configuration on m10 devices.
Also, add extra gps info to status output.
Add gpssats cli command
TODO:
Bonus changes:
showdebug on cli