Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pollVersion() and pollGnssCapabilities() if gps_auto_config = OFF #10082

Merged
merged 2 commits into from
May 31, 2024

Conversation

WizzardDr
Copy link
Contributor

Modified gps_ublox.c to skip pollVersion() and pollGnssCapabilities() if gps_auto_config = OFF. This is to support an RX only UART connection of the GPS module.

I need to use my preconfigured GPS without connecting it to the FC UART RX (just TX), so via the CLI I have set set gps_auto_config = OFF.

set gps_auto_config = OFF alone doesn't work since pollVersion() and pollGnssCapabilities() are still continually polled.

If the GPS RX isn't connected the UBX_ACK_GOT_ACK isn't received by the FC which results in repeated a GPS timeout waiting for a "GPS Version" response despite valid GPS data being received.

My solution is to skip pollVersion() and pollGnssCapabilities() if GPS auto config is disabled.

This solution resolved the above problem but may or may not cause other problems if the GPS Version and GNSS capabilities are needed (while GPS auto config is disabled) for something else that I am unaware of.

WizzardDr and others added 2 commits May 24, 2024 22:13
… = OFF`

Modified gps_ublox.c to skip `pollVersion()` and `pollGnssCapabilities()` if `gps_auto_config = OFF`. This is to support an RX only UART connection of the GPS module.
Fix formatting.
@mmosca mmosca added this to the 8.0 milestone May 31, 2024
@mmosca mmosca merged commit 7b21635 into iNavFlight:master May 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants