Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange top bar to fit on 1024px screens #2266

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Nov 27, 2024

There is an issue on 1024px wide screens where the dataflash box spills over on to a new row. This hides the save and reboot button. This change has a slight rearrangement, stacking the profile selection boxes vertically. This considerably reduces the width taken up by this. I have also made it so that the dataflash box will hide if the screen is too narrow (less than 1060px).

This needs testing with a flight controller with dataflash connected. Just to make sure the dataflash area is ok when populated.

Fixes #2265

Current layout on large screen
image

Current layout on 1024 x 768 screen
image
Notice missing save and reboot button

New layout on large screen
image

New layout on 1024 x 769 screen
image

Technically a bug fix. So should be fine for the next 8.0 RC if the change is wanted.

@MrD-RC MrD-RC added this to the 8.0 milestone Nov 27, 2024
@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 28, 2024

It looks like the data flash box needs to be a little wider on the change. Thanks for checking it out @Jetrell

- Added line break to make better use of space with no overlapping of the box
- Changed the JS to use i18n to get the correct text for the dataflash box
@MrD-RC MrD-RC added the Bug label Nov 28, 2024
@Jetrell
Copy link

Jetrell commented Nov 28, 2024

I'm not sure what size monitor you have tested it on Darren. I found results similar to the pictures you added in your post, when reducing the resolution of a 1920 x 1080 display.
But I also deliberately tested it on a laptop with a smaller screen 1366 x 768.
And with that smaller monitor, using both these commits, the 1024 x 768 resolution doesn't show the DataFlash box at all.

1024 x 768

And these changes are also effecting the layout above 1060px.. As can be seen below with 1366 x 768 screen.
The box is so compressed that the used memory status line is hardly visible.

1366 x 768

While this is what 1366 x 768 looks like with the present configurator screen format.

1366 x 768 as is

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 28, 2024

That's as expected, other than the visible html on the dataflash box. I will get that sorted tonight.

At 1024px wide. The dataflash area should not be visible. There is only so much space. And that seemed like the least important part to keep. The sensors, profiles, and failsafe/warning areas seem more important to me. This stop the top bar from spilling over and hiding the save and reboot button.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 28, 2024

After latest change

Full screen
image

1024 x 768
image

@MrD-RC MrD-RC merged commit 6dd9cea into master Nov 30, 2024
5 checks passed
@MrD-RC MrD-RC deleted the MrD_Rearrange-top-bar-to-be-1024px-safe branch November 30, 2024 07:57
@b14ckyy
Copy link
Collaborator

b14ckyy commented Nov 30, 2024

Very nice change.
also don't forget that its probably not only the resolution but also the UI Scaling in the OS itself thats usually >100% on many laptop screens. Especially small ones like 11"-13". Even with 1080p on a 11" screen the default scaling is 200% so effectively a 960x590 equivalent. But as long as we can cover a 1024x768@100% we should cover 99.9% of systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total mess in configirator on small screens
3 participants