Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it impossible to modify USB VCP serial port assignment in the GUI #1990

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented Mar 7, 2024

image

@DzikuVx DzikuVx added this to the 8.0 milestone Mar 7, 2024
@stronnag
Copy link
Collaborator

stronnag commented Mar 7, 2024

Perfect, all the other useful cases require premeditated acts in the CLI (and still need MSP). And if the user is obtuse enough to disable VCP MSP via the CLI, they deserve the consequences.

@stronnag
Copy link
Collaborator

stronnag commented Mar 7, 2024

But why even show VCP?

@DzikuVx
Copy link
Member Author

DzikuVx commented Mar 8, 2024

Hmm... good question @stronnag maybe this is the way indeed

@YI-BOYANG
Copy link
Contributor

image
Haha, this is really a good PR, I also accidentally turned off the USB VCP once, which made me no longer able to connect to the configurator and had to re-burn the firmware.
At that time I thought, why can't you forbid the user to operate the switch of USB VCP like BF configurator? So I refer to the code of the BF configurator and implement this function on the INAV configurator.
In the end, I didn't submit the PR because I wasn't sure if the INAV configurator left the ability for the player to operate the USB VCP, or what else.

@DzikuVx
Copy link
Member Author

DzikuVx commented Mar 12, 2024

@YI-BOYANG I think that @stronnag suggestion to remove VCP from this table completely will be a better idea. I will handle that as soon as I find some time

@DzikuVx DzikuVx merged commit cb9a6d6 into master Mar 15, 2024
@DzikuVx DzikuVx deleted the dzikuvx-usb-vcp-constant-function branch March 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants