Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number entity in 2022.1.0dev #667

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Fix number entity in 2022.1.0dev #667

merged 4 commits into from
Jan 25, 2022

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Dec 7, 2021 •
edited
Loading

Fixes #665

Broken by home-assistant/core#61100.

(requires 2022.1.0dev)

@github-actions github-actions bot added the bug Something isn't working label Dec 7, 2021
@iMicknl iMicknl changed the title Fix number entity in 2021.12.0 Fix number entity in 2022.1.0dev Dec 7, 2021
@iMicknl iMicknl mentioned this pull request Dec 7, 2021
Closed
1 task
@tetienne
Copy link
Collaborator

tetienne commented Dec 7, 2021

Indeed, nice clean up.

Quentame
Quentame approved these changes Dec 14, 2021
View reviewed changes
Copy link

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice

@Mariusthvdb
Copy link

is there any chance this can get merged some time soon? Since all checks have passed, maybe another look is all that is needed? would be hugely appreciated .
thanks!

@iMicknl
Copy link
Owner Author

iMicknl commented Dec 15, 2021

is there any chance this can get merged some time soon? Since all checks have passed, maybe another look is all that is needed? would be hugely appreciated . thanks!

No. And I thought I made myself clear in #665 already. This fix will break current functionality in 2021.12, thus we will merge this only after 2022.1 is released.
If you don't want to face issues, don't run beta versions on your production instance, or merge the required change in your integration.

I will sometimes hit 'update branch' on this pull request, so you can use this version manually with the latest changes of this integration, but more than that I can't do.

@iMicknl iMicknl mentioned this pull request Jan 13, 2022
Merged
@iMicknl iMicknl merged commit 8da903f into master Jan 25, 2022
@iMicknl iMicknl deleted the fix/665 branch January 25, 2022 22:00
tetienne added a commit that referenced this pull request Jan 26, 2022
@tetienne
Revert "Fix number entity (#667)"
5235ad4 
This reverts commit 8da903f.
@tetienne tetienne mentioned this pull request Jan 26, 2022
Merged
iMicknl added a commit that referenced this pull request Jan 26, 2022
@tetienne @iMicknl
Revert "Fix number entity (#667)" (#726)
a033cf2 
This reverts commit 8da903f.

Co-authored-by: Mick Vleeshouwer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentame Quentame Quentame approved these changes

@tetienne tetienne tetienne approved these changes

@vlebourl vlebourl Awaiting requested review from vlebourl vlebourl is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OverkizNumber' object has no attribute '_attr_min_value'
5 participants
@iMicknl @tetienne @Mariusthvdb @Quentame @vlebourl