Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code dedicated to gate opener #449

Merged
merged 1 commit into from
May 27, 2021

Conversation

tetienne
Copy link
Collaborator

This device behaves like a cover (use closure state). There is no need to have code dedicated to it.

{
  "commands": [
    {
      "commandName": "advancedRefresh",
      "nparams": 1
    },
    {
      "commandName": "close",
      "nparams": 0
    },
    {
      "commandName": "delayedStopIdentify",
      "nparams": 1
    },
    {
      "commandName": "getName",
      "nparams": 0
    },
    {
      "commandName": "identify",
      "nparams": 0
    },
    {
      "commandName": "open",
      "nparams": 0
    },
    {
      "commandName": "refreshPedestrianPosition",
      "nparams": 0
    },
    {
      "commandName": "setClosure",
      "nparams": 1
    },
    {
      "commandName": "setClosureOrPedestrianPosition",
      "nparams": 1
    },
    {
      "commandName": "setDeployment",
      "nparams": 1
    },
    {
      "commandName": "setName",
      "nparams": 1
    },
    {
      "commandName": "setPedestrianPosition",
      "nparams": 0
    },
    {
      "commandName": "startIdentify",
      "nparams": 0
    },
    {
      "commandName": "stop",
      "nparams": 0
    },
    {
      "commandName": "stopIdentify",
      "nparams": 0
    },
    {
      "commandName": "wink",
      "nparams": 1
    },
    {
      "commandName": "runManufacturerSettingsCommand",
      "nparams": 2
    },
    {
      "commandName": "keepOneWayControllersAndDeleteNode",
      "nparams": 0
    },
    {
      "commandName": "pairOneWayController",
      "nparams": 2
    },
    {
      "commandName": "sendIOKey",
      "nparams": 0
    },
    {
      "commandName": "setConfigState",
      "nparams": 1
    },
    {
      "commandName": "unpairAllOneWayControllersAndDeleteNode",
      "nparams": 0
    },
    {
      "commandName": "unpairAllOneWayControllers",
      "nparams": 0
    },
    {
      "commandName": "unpairOneWayController",
      "nparams": 2
    }
  ],
  "states": [
    {
      "type": "DataState",
      "qualifiedName": "core:AdditionalStatusState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:ClosureState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "good",
        "low",
        "normal",
        "verylow"
      ],
      "qualifiedName": "core:DiscreteRSSILevelState"
    },
    {
      "type": "DataState",
      "qualifiedName": "core:ManufacturerSettingsState"
    },
    {
      "type": "DataState",
      "qualifiedName": "core:NameState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "closed",
        "open",
        "pedestrian",
        "unknown"
      ],
      "qualifiedName": "core:OpenClosedPedestrianState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:PedestrianPositionState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:PriorityLockTimerState"
    },
    {
      "type": "ContinuousState",
      "qualifiedName": "core:RSSILevelState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "available",
        "unavailable"
      ],
      "qualifiedName": "core:StatusState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "comfortLevel1",
        "comfortLevel2",
        "comfortLevel3",
        "comfortLevel4",
        "environmentProtection",
        "humanProtection",
        "userLevel1",
        "userLevel2"
      ],
      "qualifiedName": "io:PriorityLockLevelState"
    },
    {
      "type": "DiscreteState",
      "values": [
        "LSC",
        "SAAC",
        "SFC",
        "UPS",
        "externalGateway",
        "localUser",
        "myself",
        "rain",
        "security",
        "temperature",
        "timer",
        "user",
        "wind"
      ],
      "qualifiedName": "io:PriorityLockOriginatorState"
    }
  ],
  "dataProperties": [
    {
      "value": "500",
      "qualifiedName": "core:identifyInterval"
    }
  ],
  "widgetName": "PositionableGateWithPedestrianPosition",
  "uiProfiles": [
    "StatefulCloseableGateOpener",
    "StatefulCloseable",
    "Closeable",
    "OpenClose"
  ],
  "uiClass": "Gate",
  "qualifiedName": "io:GateOpenerIOComponent",
  "type": "ACTUATOR"
}

@tetienne tetienne requested review from iMicknl and vlebourl as code owners May 23, 2021 15:23
@github-actions github-actions bot added the enhancement New feature or request label May 23, 2021
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! The only thing we could do is see if we can support setPedestrianPosition as a custom service.

@tetienne
Copy link
Collaborator Author

@iMicknl if someone request it yes why not. But I don't see what will be the difference with the closure.

@tetienne tetienne merged commit e1ce5c8 into master May 27, 2021
@tetienne tetienne deleted the enhancement/remove-pedestrian-dedicated-code branch May 27, 2021 18:36
@iMicknl
Copy link
Owner

iMicknl commented May 27, 2021

@iMicknl if someone request it yes why not. But I don't see what will be the difference with the closure.

With a gate opener you can open it for 50% for some devices (only 1 of the two sides), however lets wait until someone requests this indeed.

     "values": [
        "closed",
        "open",
        "pedestrian",
        "unknown"
      ],
      "qualifiedName": "core:OpenClosedPedestrianState"

It seems that setPedestrianPosition can be used to set the status to 'pedestrian'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants