Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cover implementation for devices with only cycle command #184

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Fix cover implementation for devices with only cycle command #184

merged 1 commit into from
Jul 28, 2020

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jul 27, 2020

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Jul 27, 2020
@iMicknl iMicknl marked this pull request as ready for review July 28, 2020 12:51
@tetienne
Copy link
Collaborator

It's weird but we have no choice.

@iMicknl
Copy link
Owner Author

iMicknl commented Jul 28, 2020

It's weird but we have no choice.

Fully agree. Once we can utilise SUPPORT_TOGGLE as the only option, I happily move back!

@iMicknl iMicknl merged commit 1b4d1ba into master Jul 28, 2020
@iMicknl iMicknl deleted the fix/146_2 branch July 28, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlebourl vlebourl vlebourl approved these changes

@tetienne tetienne tetienne approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iMicknl @tetienne @vlebourl