Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device attributes to attributes #180

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Add device attributes to attributes #180

merged 1 commit into from
Jul 27, 2020

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jul 27, 2020

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Jul 27, 2020
tetienne
tetienne requested changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@tetienne tetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove this line please:

ha-tahoma/custom_components/tahoma/tahoma_device.py

Line 82 in 426af89

attr[ATTR_RSSI_LEVEL] = self.select_state(CORE_RSSI_LEVEL_STATE)

This last one is included with the next loop.

@iMicknl
Copy link
Owner Author

iMicknl commented Jul 27, 2020

Can you also remove this line please:

ha-tahoma/custom_components/tahoma/tahoma_device.py

Line 82 in 426af89

attr[ATTR_RSSI_LEVEL] = self.select_state(CORE_RSSI_LEVEL_STATE)

This last one is included with the next loop.

I don't think this is related to this PR, but I am also not sure if we should remove ATTR_RSSI_LEVEL which is a default named property from HA. The others are using the original names from HA, thus core:RSSILevelState.

@tetienne tetienne merged commit c7ca453 into master Jul 27, 2020
@tetienne tetienne deleted the enhancement/show_attributes branch July 27, 2020 14:32
iMicknl added a commit that referenced this pull request Jul 27, 2020
@iMicknl
Squashed commit of the following:
fb16f84 
commit c7ca453
Author: Mick Vleeshouwer <[email protected]>
Date:   Mon Jul 27 16:32:04 2020 +0200

    Add device attributes to attributes (#180)

commit 0883cf6
Author: tetienne <[email protected]>
Date:   Mon Jul 27 14:14:38 2020 +0200

    Fix assumed state (#178)

commit b490d79
Author: tetienne <[email protected]>
Date:   Mon Jul 27 14:02:58 2020 +0200

    Fix execute_command call (#176)

commit 9560cfa
Author: Mick Vleeshouwer <[email protected]>
Date:   Sun Jul 26 13:01:16 2020 +0200

    Add more ui_classes and sort them alphabetically (#168)

commit b01f2ca
Author: Mick Vleeshouwer <[email protected]>
Date:   Sun Jul 26 12:53:15 2020 +0200

    Improve support for GasSensor, ThermalEnergySensor, WaterSensor and add support for Siren Status (#170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlebourl vlebourl vlebourl approved these changes

@tetienne tetienne tetienne approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iMicknl @vlebourl @tetienne